Add MessageData module to include sparkpost_data in Mail::Message#62
Open
silvabox wants to merge 1 commit into
Open
Add MessageData module to include sparkpost_data in Mail::Message#62silvabox wants to merge 1 commit into
sparkpost_data in Mail::Message#62silvabox wants to merge 1 commit into
Conversation
`sparkpost_data` is addded to the message object through metaprogramming in the `mail` method. Instances of Mail::Message created outside of this method (e.g. deserializing from a data store) will therefore not have this attribute defined. This change separates the attribute definition to ensure it exists on the object's class and not just the instance's singleton class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sparkpost_datais addded to the message object through metaprogrammingin the
mailmethod. Instances of Mail::Message created outside ofthis method (e.g. deserializing from a data store) will therefore not have
this attribute defined. This change separates the attribute definition
to ensure it exists on the object's class and not just the instance's
singleton class.
Closes #59