Implement BASE_PATH environment variable#890
Implement BASE_PATH environment variable#890ItsSpaceMan wants to merge 6 commits intothedevs-network:mainfrom
Conversation
|
@poeti8 are you able to take a look at this PR? |
|
@ItsSpaceMan Yes |
|
Is this getting any lights? I think it's a fairly important feature that would benefit lots of users. @poeti8 |
yq2028
left a comment
There was a problem hiding this comment.
in file : server/utils/utils.js , this snippet is wrong. it make the short link include the base_path no matter what the env.SHORT_URLS_INCLUDE_PATH is true or false.
if (linkDomain === env.DEFAULT_DOMAIN) {
path = env.BASE_PATH;
Good catch; cleaned up. Thanks @yq2028. Added a new commit as well to fix up some main page logic (see 3710b71). |
PR to implement base path, such that the service can run on
/kutt,/url-shortener, or any other base path specified. Ran through the application several times with BASE_PATH omitted and set, and everything is looking good.