Add Faraday 2.x gems for persistent connections#13544
Draft
pablomh wants to merge 2 commits into
Draft
Conversation
Member
|
Can one of the admins verify this patch? |
1 similar comment
Member
|
Can one of the admins verify this patch? |
zjhuntin
reviewed
Jun 24, 2026
zjhuntin
left a comment
zjhuntin
left a comment
Contributor
There was a problem hiding this comment.
Minor nit: all 3 changelog entries say Tue May 27 2026 but May 27, 2026 was a Wednesday. rpmbuild warns bogus date in %changelog for each spec.
pablomh
force-pushed
the
faraday2-packaging
branch
from
e9c61cd to
9109669
Compare
New packages: - rubygem-faraday2 (2.12.2) — co-installable alongside faraday 1.x - rubygem-faraday-net_http_persistent2 (2.3.0) — adapter for Faraday 2.x - rubygem-net-http-persistent (4.0.8) — persistent HTTP connection pooling These enable persistent TCP+TLS connection reuse in smart-proxy, eliminating per-request connection setup overhead.
pablomh
force-pushed
the
faraday2-packaging
branch
from
9109669 to
f48bc23
Compare
Member
|
ok to test |
Member
|
CI fails as the patch is missing a |
Remove rubygem-net-http-persistent from this branch and add package_manifest.yaml entries for the remaining Faraday 2 packages. The net-http-persistent package is handled separately in theforeman#13432. Co-authored-by: Cursor <cursoragent@cursor.com>
pablomh
changed the title
Author
|
I've moved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two new packages to enable Faraday 2.x with persistent HTTP connections, co-installable alongside the existing Faraday 1.x packages.
rubygem-net-http-persistentwas removed from this PR and is handled separately in #13432. That package can be consumed by both Katello andforeman-proxy.Packages
Why co-installable (not an upgrade)
Faraday 1.x is still required by
ms_rest/ms_rest_azure(pinsfaraday < 2.0.0) andkatello(pinsfaraday >= 1.10.2, < 1.11.0). Both constraints will be removed by upcoming PRs, after which the 1.x packages can be retired.Dependency chain
Ruby 3.0 compatibility
All versions tested on Ruby 3.0 (RHEL 9 / Satellite Stream). Key constraints:
faraday-net_httpmust stay at 3.1.0 (3.4+ requiresnet-http >= 0.5, RHEL ships 0.1.1) - this is a transitive dep of faraday2, not a separate packageconnection_poolmust stay below 3.0 (3.0+ uses Ruby 3.1 syntax) - already at 2.5.5