Add test for client_ip in WAF violation logs#1
Conversation
This test ensures that when a WAF rule violation is detected, the reported client_ip in the logs is correctly resolved using getClientAddress(r). It covers cases where the IP comes from r.RemoteAddr and when it is provided by Caddy's internal variable. Co-authored-by: thelogh <52915242+thelogh@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Adds a new test
TestWAFViolationLogClientIPtocoraza_test.goto verify the fix in PR corazawaf#306. The test ensures that theclient_iplogged during WAF rule violations is correctly retrieved usinggetClientAddress(r), supporting bothRemoteAddrand Caddy-provided client IPs.PR created automatically by Jules for task 1207559340494254614 started by @thelogh