Merged
Conversation
Implement Ed25519 signature verification following the JS and Rust SDK reference implementations. Fix Container setup to generate PKCS8 PEM via JOSE, copy it into the container, and pass the signing key file path. Add tampered signature test case and fix existing test issues. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The /etc/esdb directory does not exist in the container image. Use /tmp/signing-key.pem instead, matching the Rust SDK approach. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add Ping and VerifyAPIToken sections - Fill in Verify Hash and Verify Signature sections - Add Listing Event Types section - Add Testcontainer signing key and manual client docs - Fix error patterns from 3-tuple to 2-tuple - Fix typos and syntax errors in code examples - Replace "vector" terminology with "list" - Add missing notes (EventQL query, recursive reading) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Rename app from :EventSourcingDB to :eventsourcingdb (Elixir convention) - Rename IsEventQLTrue to IsEventQLQueryTrue (matching Go SDK) - Add observe_events tests for lower_bound and from_latest_event - Add @doc for with_signing_key/1 and get_verification_key/1 - Fix typo in TestContainer moduledoc Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The release pipeline now also updates the dependency version in README.md alongside mix.exs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
goloroden
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample prompt:
The feature to implement is
Event.verify_signature/2. The code has@TODOcomments with places where the implementation shall happen and instructions for that particalur locations. Since this is an elixir adaptation that happens to already exist in other programming languages, I linked reference implementations in javascript and rust.There are two test cases prepared with
@TODO fix this testto enable TDD.Ideally use the erlang native crypto libraries for implementation. If the
joselibrary is useful, make use of that (otherwise we are happy to remove that dependency). You find# Failure attemptscomments code, that doesn't work (yet?). You may find helpful code in there (that wasn't properly stitched together), you are free to discard it.