Bug Fix: Incorrect Static Paths Prioritising - #243
Open
halidovz wants to merge 1 commit into
Open
Conversation
Author
|
Hey @lezhnev74 , could you please review this when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When OpenAPI
serversare defined and there are multiple paths with the same number of segments—some dynamic and some static—the validator may incorrectly match both paths.Example OpenAPI definition:
Incoming request:
Actual behavior:
Both paths
/products/{product}/images/{image}and/products/{product}/images/thumbnailsare matched.Expected behavior:
Only the more specific, static path
/products/{product}/images/thumbnailsshould match.Cause:
The current path matching logic compares only the relative path without properly including the server prefix (e.g.,
/v1). This leads to ambiguous or incorrect matching when evaluating path candidates of equal length.Fix:
Ensure that the matching logic compares full paths—including the server prefix—when determining the best match.