Skip to content

Add support for new Map type introduced in Erlang R17#6

Open
gbour wants to merge 3 commits into
therve:masterfrom
gbour:feat-map
Open

Add support for new Map type introduced in Erlang R17#6
gbour wants to merge 3 commits into
therve:masterfrom
gbour:feat-map

Conversation

@gbour

@gbour gbour commented Jul 12, 2016

Copy link
Copy Markdown

No description provided.

@therve

therve commented Jul 13, 2016

Copy link
Copy Markdown
Owner

Do you feel like adding some tests for it? I think I fixed tests in master now.

@coveralls

coveralls commented Jul 13, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.5%) to 94.054% when pulling 2f6a487 on gbour:feat-map into 8c5d643 on therve:master.

@coveralls

coveralls commented Jul 14, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) to 94.542% when pulling 61a9e12 on gbour:feat-map into 67d0c94 on therve:master.

@gbour

gbour commented Jul 14, 2016

Copy link
Copy Markdown
Author

Great news 👍
I've added map parser/packer tests

Comment thread twotp/packer.py
Pack a map.
"""
length = len(term)
packetData = (self.packChar(self.MAGIC_MAP) + self.packInt(length))

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the parenthesis here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants