Skip to content
This repository was archived by the owner on Jun 12, 2026. It is now read-only.

enable bubbling of the events scrollSpy:enter and scrollSpy:exit #10

Open
Mithgol wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enable bubbling of the events scrollSpy:enter and scrollSpy:exit #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eea905
fix a typo in README.md
Mithgol May 28, 2014
4db9531
enable bubbling of the events `scrollSpy:enter` and `scrollSpy:exit`
Mithgol Jul 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ $.winSizeSpy().on('scrollSpy:winSize', funcy)

# Contributions

Please provide pull requests for additional features. Test cases would be most weclome!
Please provide pull requests for additional features. Test cases would be most welcome!

Thank you contributors:

Expand Down
6 changes: 3 additions & 3 deletions scrollspy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
var lastTick = element.data('scrollSpy:ticks');
if (typeof lastTick != 'number') {
// entered into view
element.triggerHandler('scrollSpy:enter');
element.trigger('scrollSpy:enter');
}

// update tick id
Expand All @@ -84,7 +84,7 @@
var lastTick = element.data('scrollSpy:ticks');
if (typeof lastTick == 'number' && lastTick !== ticks) {
// exited from view
element.triggerHandler('scrollSpy:exit');
element.trigger('scrollSpy:exit');
element.data('scrollSpy:ticks', null);
}
});
Expand Down Expand Up @@ -222,4 +222,4 @@
return $.scrollSpy($(this), options);
};

})(jQuery);
})(jQuery);