18 support for metadata flags - #19
Merged
Merged
Conversation
To allow for the metadata flags to participate in the cache key of the lru cache, there's now only 1 *thing* that does the actual api call. For example, we can add the flags and chain a method call, which will merge the flags & the arguments from the chained method call. The added `enum.StrEnum` is not in use for now, since typing strings directly without namespacing them behind an attribute access is less friction for library consumption. But using it will aid in test cases and not having to maintain a type & a corresponding lookup. Signed-off-by: Bivas Kumar <thetrotfreak@yahoo.com>
Skips the smoke test since it actually API calls (done before pushing to pypi). Signed-off-by: Bivas Kumar <thetrotfreak@yahoo.com>
In smoke test, the test case that tests import is floated to top, since it's logically wrong to place it after other test cases! (as they'd import datamuse beforehand). Signed-off-by: Bivas Kumar <thetrotfreak@yahoo.com>
Having that in between the bulleted examples makes up for a bad indentation and look. Fixes typo in docs#examples. Signed-off-by: Bivas Kumar <thetrotfreak@yahoo.com>
To 3, adding support for metadata flags. Signed-off-by: Bivas Kumar <thetrotfreak@yahoo.com>
thetrotfreak
force-pushed
the
18-support-for-metadata-flags
branch
from
January 26, 2026 15:34
b77a48a to
73db279
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18 (partially)