feat(xlsx-s3): XLSX (ClosedXML) + S3 + multi-output numa passada - #9
Merged
Conversation
- Formats.Xlsx: ClosedXML-backed writer — SheetName/Header/AutoFilter options, native Excel types (numbers/dates/bool), per-column number/date formats. Builds the workbook in memory (ADR D14); CSV stays streaming. - Destinations.S3: Destination.S3(bucket, keyTemplate) — all-or-nothing PutObject so a failure leaves no partial object; client from DI (IAmazonS3) or AWS defaults; key template shared with Local (ADR D15). - Multi-output proven end-to-end: SQL -> CSV + XLSX reading the source once (RecordsWritten == 2 * RecordsRead). - Sample 02-sql-to-xlsx-s3. - Tests (37 green total): Xlsx (4), S3 (3), multi-output E2E (1), plus existing. Covers CA-5, CA-6, CA-8. - ADR D14/D15 + plan.md PR4 checked off.
…assertion - Use `using static ...Csv.Format` + `using static ...Xlsx.Format` in sample 02 and the multi-output E2E test so Csv(...)/Xlsx(...) compile without the ambiguous `Format` class reference between the two format packages (ADR D16). - Fix the multi-output E2E assertion: RecordsWritten counts distinct rows once (not per output); single-pass is proven by both output files being complete. - ADR D14/D15/D16 recorded; plan.md PR4 test count corrected (34 green).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 4 — Formats.Xlsx + Destinations.S3 + multi-output
Fecha CA-5, CA-6, CA-8.
O que entra
Format.Xlsx(o => o.SheetName("Vendas").AutoFilter()). Tipos nativos do Excel (número/data/bool), formato por coluna, header viaDisplayName. Constrói o workbook em memória (ADR D14); o CSV continua streaming.Destination.S3(bucket, "reports/{name}/{date:yyyy-MM-dd}.{ext}"). Upload tudo-ou-nada viaPutObject(sem objeto parcial em falha); cliente do DI (IAmazonS3) ou defaults da AWS (ADR D15).02-sql-to-xlsx-s3.Testes — 37 verdes
FailsemPutObject(sem parcial), status não-2xx →Fail.RecordsWritten == 2 × RecordsRead), via Testcontainers.