Skip to content

Upgrade dependencies, switch to vitest, introduce eslint#32

Merged
thomaseizinger merged 2 commits intothomaseizinger:masterfrom
pronebird:upgrade
Dec 14, 2025
Merged

Upgrade dependencies, switch to vitest, introduce eslint#32
thomaseizinger merged 2 commits intothomaseizinger:masterfrom
pronebird:upgrade

Conversation

@pronebird
Copy link
Copy Markdown
Contributor

@pronebird pronebird commented Dec 13, 2025

I have spent a lot of time trying to fix #31 today, however eventually I realized that remark escapes link refs shortcuts without actual links, so I'll probably move on with a bash script for my limited use case. However I have decided to push this PR to refresh what appears to be a very old GitHub action.

Changes:

  • Update all dependencies to the latest
  • Switch from jest to vitest. It was not my intention but it just didn't work with the recent unified and fails to understand export ... from '..' syntax in node_modules/unified/index.js. vitest just works and it has a watch mode too which is super handy for auto-rerunning tests (new package.json command: nom run test-watch)
  • Fix "first_release" test which stopped working with the recent remark. Shorcut link refs without the corresponding links are parsed as text (used to be link refs)
  • Reformat everything with prettier
  • New ESLint config
  • Sorry for single quotes, not sure what changed them either my IDE or prettier.
  • Included the output of yarn build in this PR

Copy link
Copy Markdown
Owner

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is very appreciated! Any chance you could fix the single quotes just to reduce the noise a bit?

Plus, if you are adding prettier, can you add a CI step to enforce it?

@pronebird
Copy link
Copy Markdown
Contributor Author

Thank you, this is very appreciated! Any chance you could fix the single quotes just to reduce the noise a bit?

Plus, if you are adding prettier, can you add a CI step to enforce it?

I can revert the quotes. However prettier was already there, maybe no one ran npm run format before? Not sure.

@pronebird pronebird force-pushed the upgrade branch 17 times, most recently from a97735d to 5e1913c Compare December 14, 2025 07:07
@pronebird
Copy link
Copy Markdown
Contributor Author

pronebird commented Dec 14, 2025

Cleaned up irrelevant changes including prettier reformatting. Re-ran webpack. I will not be addressing prettier setup in this PR. Everything is already in place but seemingly unused. If you have desire to get formatting under control, here is what can be done:

  • Reformat all code with npm run format
  • Add CI step to run npm run format-check to enforce that

On a side note:

  • The pre-commit hook nagging about yarn build is hit and miss.
  • It seems that yarn is used instead of npm. Not sure yarn is the thing in 2025. Personally I'd switch to npm.

@thomaseizinger
Copy link
Copy Markdown
Owner

It seems that yarn is used instead of npm. Not sure yarn is the thing in 2025. Personally I'd switch to npm.

Interesting. It has been a while that I did frontend work so I am not fully aware of the developments here.

Thank you for the contribution! :)

@thomaseizinger thomaseizinger changed the title Upgrade project to the latest dependencies, switch from jest to vitest Upgrade dependencies and switch to vitest Dec 14, 2025
@thomaseizinger thomaseizinger changed the title Upgrade dependencies and switch to vitest Upgrade dependencies, switch to vitest, introduce eslint Dec 14, 2025
@thomaseizinger thomaseizinger merged commit 5dc66a9 into thomaseizinger:master Dec 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make links to tags optional

2 participants