-
-
Notifications
You must be signed in to change notification settings - Fork 397
Document existing ARM64 build support for Raspberry Pi 5 #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
6ce56bb
647ee3d
d4a7d3d
43a7fe4
9860fa1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -3,11 +3,13 @@ import * as fs from 'fs' | |||||||
| import * as path from 'path' | ||||||||
| import * as dotProp from 'dot-prop' | ||||||||
|
|
||||||||
| // Linux AppImage build for multiple architectures | ||||||||
| // Builds for: x64, ARM64 (Raspberry Pi 5), and ARMv7l (Raspberry Pi 4 and older) | ||||||||
| const linuxAppImage: builder.CliOptions = { | ||||||||
| x64: true, | ||||||||
| ia32: false, | ||||||||
| armv7l: true, | ||||||||
| arm64: true, | ||||||||
| arm64: true, // Raspberry Pi 5 support | ||||||||
| projectDir: './build/clean', | ||||||||
| publish: 'always', | ||||||||
| } | ||||||||
|
|
@@ -21,11 +23,13 @@ const linuxSnap: builder.CliOptions = { | |||||||
| publish: 'always', | ||||||||
| } | ||||||||
|
|
||||||||
| // Linux Deb package build for multiple architectures | ||||||||
| // Builds for: amd64 (x64), arm64 (Raspberry Pi 5), and armhf (Raspberry Pi 4 and older) | ||||||||
| const linuxDeb: builder.CliOptions = { | ||||||||
| x64: true, | ||||||||
| ia32: false, | ||||||||
| armv7l: true, | ||||||||
| arm64: true, | ||||||||
| arm64: true, // Raspberry Pi 5 support | ||||||||
| projectDir: './build/clean', | ||||||||
| publish: 'always', | ||||||||
| } | ||||||||
|
|
@@ -76,6 +80,7 @@ async function executeBuild() { | |||||||
| await buildWithOptions(winAppx, { platform: 'win', package: 'appx' }) | ||||||||
| break | ||||||||
| case 'linux': | ||||||||
| console.log('Building Linux packages for architectures: x64, arm64 (Raspberry Pi 5), armv7l') | ||||||||
|
||||||||
| console.log('Building Linux packages for architectures: x64, arm64 (Raspberry Pi 5), armv7l') | |
| console.log('Building Linux packages (see individual build logs for architectures)') |
Copilot
AI
Dec 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logging code only captures x64 and arm64 architectures, but the actual build configurations include armv7l as well. The log output will be incomplete and won't show that armv7l is being built for AppImage and Deb packages. Consider adding armv7l to the architectures array to provide accurate build information.
| if (options.arm64) architectures.push('arm64') | |
| if (options.arm64) architectures.push('arm64') | |
| if (options.armv7l) architectures.push('armv7l') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README states that Snap format is available for all Linux architectures (x64, ARM64, ARMv7l), but the linuxSnap configuration in package.ts explicitly has arm64: false and armv7l: false. The Snap package is only built for x64. The README should clarify which formats are available for which architectures, for example: "AppImage and Deb: x64, ARM64, ARMv7l; Snap: x64 only".