Skip to content

Fix UI tests: correct expandTopic parameter order and CI workflow #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasnordquist merged 3 commits into from
Dec 20, 2025
Merged

Fix UI tests: correct expandTopic parameter order and CI workflow #936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bfa6d2
Initial plan
Copilot Dec 20, 2025
8f328ca
Fix expandTopic parameter order in UI tests
Copilot Dec 20, 2025
44f2bad
Fix CI workflow to checkout PR code instead of base branch
Copilot Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ jobs:
options: --user root
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Install Packages
run: yarn install --frozen-lockfile
- name: Build
Expand All @@ -28,6 +30,8 @@ jobs:
options: --user root
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Install Packages
run: yarn install --frozen-lockfile
- name: Build
Expand All @@ -53,6 +57,8 @@ jobs:
options: --user root
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Install Packages
run: yarn install --frozen-lockfile
- name: Build
Expand Down Expand Up @@ -90,6 +96,8 @@ jobs:
--health-retries 5
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Setup Node.js
uses: actions/setup-node@v4
with:
Expand Down
10 changes: 5 additions & 5 deletions src/spec/ui-tests.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ describe('MQTT Explorer UI Tests', function () {
// When: Connect and expand topic
await connectTo('127.0.0.1', page)
await sleep(2000)
await expandTopic(page, 'livingroom/lamp')
await expandTopic('livingroom/lamp', page)

// Then: Should see lamp state
const stateTopic = await page.locator('span[data-test-topic="state"]')
Expand Down Expand Up @@ -97,7 +97,7 @@ describe('MQTT Explorer UI Tests', function () {
// When: Connect and expand topic
await connectTo('127.0.0.1', page)
await sleep(2000)
await expandTopic(page, 'kitchen/coffee_maker')
await expandTopic('kitchen/coffee_maker', page)

// Then: JSON content should be visible (check for heater key)
const valueDisplay = await page.locator('text="heater"')
Expand All @@ -119,7 +119,7 @@ describe('MQTT Explorer UI Tests', function () {
// When: Connect and expand to nested topic
await connectTo('127.0.0.1', page)
await sleep(2000)
await expandTopic(page, 'livingroom/lamp/brightness')
await expandTopic('livingroom/lamp/brightness', page)

// Then: Brightness topic should be visible and selected
const brightnessTopic = await page.locator('span[data-test-topic="brightness"]')
Expand Down Expand Up @@ -148,7 +148,7 @@ describe('MQTT Explorer UI Tests', function () {
await sleep(1000)
await clearSearch(page)
await sleep(500)
await expandTopic(page, 'kitchen/temperature')
await expandTopic('kitchen/temperature', page)

// Then: Temperature topic should be visible
const tempTopic = await page.locator('span[data-test-topic="temperature"]')
Expand All @@ -175,7 +175,7 @@ describe('MQTT Explorer UI Tests', function () {
await sleep(1000)
await clearSearch(page)
await sleep(500)
await expandTopic(page, 'kitchen/lamp')
await expandTopic('kitchen/lamp', page)

// Then: Lamp topic should be visible
const lampTopic = await page.locator('span[data-test-topic="lamp"]')
Expand Down