refactor(sts): consolidate exchange logging into one outcome log - #16
Merged
Conversation
hibare
marked this pull request as ready for review
May 25, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate exchange logging into a single deferred
Service.logExchangethat emits one structured line per request — INFO on success, WARN on denial, ERROR on internal failures — with full caller, policy, and token context on every path.Changes
Service.Exchange. Reads only from the response and*ExchangeError; no progress state insideExchange.Authorizerdrops itsloggerfield,logResultmethod, and*slog.Loggerconstructor arg — it's now a pure decision engine.ExchangeResponsegainsClientID,TokenHash,TTLtaggedjson:"-"(consistent with existingIssuer/Subject) so internal observers read full context without affecting API consumers.oidc validatedandgithub app selectedbreadcrumbs kept for triage.Example output
Granted
Denied
Internal failure