fix(server): normalize trailing slashes so /health/ returns 200 - #21
Merged
Conversation
hibare
marked this pull request as ready for review
June 18, 2026 07:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds path normalization middleware to strip trailing slashes from request URLs before they reach downstream handlers and middleware. This ensures endpoints like
/health/return 200 instead of 404, and that all path-aware middleware (loggers, telemetry, heartbeat checks) observe a single canonical path.What Changed
NormalizePathmiddleware that strips trailing slashes fromr.URL.Pathandr.URL.RawPath/unchangedTechnical Details
Chi's built-in
middleware.StripSlashesonly modifies the routing context, not the actual URL path. Middleware that readsr.URL.Pathdirectly (structured loggers, OpenTelemetry span formatters, heartbeat checks) continue to see unnormalized paths with trailing slashes. This middleware normalizes the URL at the top of the handler chain so all downstream components see consistent paths.Type of Change