Skip to content

20251125 174819#155

Closed
mpragosa-te wants to merge 21 commits into
mainfrom
20251125-174819
Closed

20251125 174819#155
mpragosa-te wants to merge 21 commits into
mainfrom
20251125-174819

Conversation

@mpragosa-te

Copy link
Copy Markdown
Contributor

phpinhei-te and others added 21 commits February 19, 2025 17:24
feat: renames core module to client

feature: moves some functions to an internal module

feat: small comment changes

feature - fixes default server url

feature - updates go sdk version on user agent

feature - includes core module prior to v7 upgrade
* feature - includes core module prior to v7 upgrade

* feature - updates go sdk version on user agent

* feature - fixes default server url

* feat: small comment changes

* feature: moves some functions to an internal module

* feat: renames core module to client

* [GitHub Bot] Generated go SDK

---------

Co-authored-by: Phellippe Lima <phpinhei@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
* update the client log

* receive the responseBody and stateCode from the agent to format error message
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread go.mod
Comment on lines +1 to +5
module github.com/thousandeyes/thousandeyes-sdk-go/v3

go 1.17
go 1.23

require github.com/stretchr/testify v1.7.2
toolchain go1.24.8

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use released Go toolchain in go.mod

go.mod now declares go 1.23 and toolchain go1.24.8 (lines 1‑5), but the CI workflows still install the version from go.mod via actions/setup-go@v3 (.github/workflows/test.yml lines 10‑13 and .github/workflows/release.yaml lines 18‑22). Go 1.23/1.24 are not released, so setup-go cannot download them and the lint/test and release jobs will fail before running any code. Unless you provision a custom toolchain, the module needs to target an available Go version to keep CI working.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants