20260129 142259#164
Closed
mpragosa-te wants to merge 22 commits into
Closed
Conversation
mpragosa-te
commented
Jan 29, 2026
mpragosa-te
commented
Contributor
- feature: wipes existing code in preparation for new version
- feat: Fixes the client content type matching regex
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #125)
- fix: fixes content-type regex matcher (fix: fixes content-type regex matcher #126)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #128)
- feature: Support new release workflow and set User-Agent header with SDK version (feature: Support new release workflow and set User-Agent header with SDK version #131)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #133)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #134)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #135)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #137)
- feat: Print the response log when the api call failed (feat: Print the response log when the api call failed #139)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #142)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #143)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #144)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #146)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #147)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #149)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #150)
- feat: Use retry http and add backoff (feat: Use retry http and add backoff #151)
- [GitHub Bot] Generated go SDK (20251017 115623 #153)
- [GitHub Bot] Generated go SDK ([GitHub Bot] Generated go SDK #158)
- [GitHub Bot] Generated go SDK
feat: renames core module to client feature: moves some functions to an internal module feat: small comment changes feature - fixes default server url feature - updates go sdk version on user agent feature - includes core module prior to v7 upgrade
* feature - includes core module prior to v7 upgrade * feature - updates go sdk version on user agent * feature - fixes default server url * feat: small comment changes * feature: moves some functions to an internal module * feat: renames core module to client * [GitHub Bot] Generated go SDK --------- Co-authored-by: Phellippe Lima <phpinhei@thousandeyes.com> Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
* update the client log * receive the responseBody and stateCode from the agent to format error message
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
mpragosa-te
requested review from
brumarqu-te,
goncarva-te,
jabrowne-te,
kevihan-te,
phpinhei-te,
rodrirod-te,
sfreitas-te and
stulowes-te
as code owners
January 29, 2026 14:23
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 899d764217
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+78
to
+82
| resp, err := c.cfg.HTTPClient.Do(request) | ||
|
|
||
| if c.cfg.Debug { | ||
| dump, err := httputil.DumpResponse(resp, true) | ||
| if err != nil { |
There was a problem hiding this comment.
In CallAPI the debug logging unconditionally calls httputil.DumpResponse(resp, true) (client/client.go) even when HTTPClient.Do returns an error without a response (e.g., DNS/TLS/network failure). In that case resp is nil and DumpResponse will panic, masking the underlying error whenever Debug is enabled. Consider checking resp != nil or only dumping when err == nil so error paths return cleanly instead of crashing.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.