Skip to content

20260129 145409#165

Closed
mpragosa-te wants to merge 22 commits into
mainfrom
20260129-145409
Closed

20260129 145409#165
mpragosa-te wants to merge 22 commits into
mainfrom
20260129-145409

Conversation

@mpragosa-te

Copy link
Copy Markdown
Contributor

phpinhei-te and others added 22 commits February 19, 2025 17:24
feat: renames core module to client

feature: moves some functions to an internal module

feat: small comment changes

feature - fixes default server url

feature - updates go sdk version on user agent

feature - includes core module prior to v7 upgrade
* feature - includes core module prior to v7 upgrade

* feature - updates go sdk version on user agent

* feature - fixes default server url

* feat: small comment changes

* feature: moves some functions to an internal module

* feat: renames core module to client

* [GitHub Bot] Generated go SDK

---------

Co-authored-by: Phellippe Lima <phpinhei@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
* update the client log

* receive the responseBody and stateCode from the agent to format error message
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5f17c9210

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +27 to +29
major_version=$(echo "${{ inputs.releaseVersion }}" | cut -d '.' -f 1)

go mod edit -module github.com/thousandeyes/thousandeyes-sdk-go/$major_version

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve Go module /vN suffix in release workflow

If the workflow input is provided as a plain semantic version like 3.1.0 (which the UI prompt suggests), major_version becomes 3 and go mod edit -module .../$major_version rewrites the module path to .../3. For Go modules with major version ≥2, the module path must include the v prefix (e.g., /v3), otherwise go get and imports will break for consumers. This only works if operators remember to include a leading v in the input; the workflow should normalize by adding v when needed.

Useful? React with 👍 / 👎.

@phpinhei-te phpinhei-te closed this Feb 9, 2026
@phpinhei-te
phpinhei-te deleted the 20260129-145409 branch February 9, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants