Skip to content

20260227 130611#175

Closed
mpragosa-te wants to merge 24 commits into
mainfrom
20260227-130611
Closed

20260227 130611#175
mpragosa-te wants to merge 24 commits into
mainfrom
20260227-130611

Conversation

@mpragosa-te

Copy link
Copy Markdown
Contributor

phpinhei-te and others added 24 commits February 19, 2025 17:24
feat: renames core module to client

feature: moves some functions to an internal module

feat: small comment changes

feature - fixes default server url

feature - updates go sdk version on user agent

feature - includes core module prior to v7 upgrade
* feature - includes core module prior to v7 upgrade

* feature - updates go sdk version on user agent

* feature - fixes default server url

* feat: small comment changes

* feature: moves some functions to an internal module

* feat: renames core module to client

* [GitHub Bot] Generated go SDK

---------

Co-authored-by: Phellippe Lima <phpinhei@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
* update the client log

* receive the responseBody and stateCode from the agent to format error message
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>
Co-authored-by: API Team <api-team@thousandeyes.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba2a17b742

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread client/client.go
resp, err := c.cfg.HTTPClient.Do(request)

if c.cfg.Debug {
dump, err := httputil.DumpResponse(resp, true)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Guard debug response dump on transport errors

When HTTPClient.Do fails it can return resp == nil, but this method still calls httputil.DumpResponse(resp, true) whenever debug mode is enabled. DumpResponse(nil, ...) panics, so a normal network failure (DNS/TLS/connect timeout) becomes a process crash only because Debug is true; add an err != nil || resp == nil guard before dumping the response.

Useful? React with 👍 / 👎.

@rodrirod-te

Copy link
Copy Markdown

#178

@rodrirod-te
rodrirod-te deleted the 20260227-130611 branch March 17, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants