Relax client-side validation to only block + in aliases.#858
Merged
Conversation
Includes both client and server-side tests. Introduces vitest for unit-testing client code, but does not yet wire it up to CI. Fixes #847
MelissaAutumn
requested changes
May 20, 2026
MelissaAutumn
left a comment
MelissaAutumn
left a comment
Member
There was a problem hiding this comment.
Thanks for splitting the function and writing the test! Unfortunately like my contractor said to me, we need to upgrade these out of code violations as well 😆.
Code looks good though, just needs the clean up.
Contributor
Author
|
Feedback has been addressed and pushed. Ready for a second look and squash-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes both client and server-side tests.
Introduces vitest for unit-testing client code, but does not yet
wire it up to CI.
Applicable Issues
Fixes #847