Add E2E tests for main accounts dashboard#866
Merged
Conversation
rwood-moz
force-pushed
the
testing/codex-add-e2e
branch
3 times, most recently
from
cc750c2 to
3cb5fbd
Compare
rwood-moz
changed the title
rwood-moz
requested review from
MelissaAutumn and
davinotdavid
and removed request for
MelissaAutumn and
davinotdavid
davinotdavid
left a comment
davinotdavid
left a comment
Contributor
There was a problem hiding this comment.
Nice! Confirmed that all tests pass while pointing to stage and using a stage account that has a subscription:
One question though:
rwood-moz
force-pushed
the
testing/codex-add-e2e
branch
from
3cb5fbd to
bf81622
Compare
davinotdavid
requested changes
May 29, 2026
|
|
||
| await expect.poll(async () => popup.url()).not.toBe('about:blank'); | ||
| expect(new URL(popup.url()).protocol).toMatch(/^https?:$/); | ||
| expect(new URL(popup.url()).host).toBe(PADDLE_HOST); |
Contributor
There was a problem hiding this comment.
Perhaps we should do toContain here instead or change the PADDLE_HOST to be environment aware as stage's URL I believe is sandbox-customer-portal.paddle.com instead
Suggested change
| expect(new URL(popup.url()).host).toBe(PADDLE_HOST); | |
| expect(new URL(popup.url()).host).toContain(PADDLE_HOST); |
Contributor
Author
There was a problem hiding this comment.
Ahh yes I tested on prod not stage, good point. Updated to use toContain so we don't need to use more env (and GHA secrets). Thanks :)
Contributor
Author
Thank you for your thorough review, much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add E2E tests to validate the main TB Accounts dashboard.
Why?
To expand the current E2E test suite.
Limitations and Notes
This test will skip if it is running on local dev stack because when running on a local stack (i.e. on PRs in CI) there won't be a TB Pro subscription setup. In the future (#771) we will add a subscribe step when running the tests on a new local dev stack, and after that this test can also be enabled to run there. In the mean time this new test will run on stage after main merges, and on prod in the nightly test suite (on mobile and desktop).
My first patch primarily developed by Codex.
Applicable Issues
Fixes #313.
Screenshots
BrowserStack links running the new dashboard tests: