refactor(cherrypickapproved): remove test status check (#25)

Remove test status check and related test cases

Author: wuhuizuo

pkg/plugins/cherrypickapproved/cherrypickapproved.go

@@ -173,19 +173,6 @@ func (h *handler) handle(log *logrus.Entry, gc plugins.PluginGitHubClient, e git
 		return nil
 	}
 
-	// Check the PR state to not have failed tests
-	combinedStatus, err := h.GetCombinedStatus(gc, org, repo, e.PullRequest.Head.SHA)
-	if err != nil {
-		return fmt.Errorf("get combined status: %w", err)
-	}
-	for _, status := range combinedStatus.Statuses {
-		state := status.State
-		if state == github.StatusError || state == github.StatusFailure {
-			log.Infof("Skipping PR %d because tests failed", prNumber)
-			return nil
-		}
-	}
-
 	// Validate the labels
 	issueLabels, err := h.GetIssueLabels(gc, org, repo, prNumber)
 	if err != nil {

pkg/plugins/cherrypickapproved/cherrypickapproved_test.go

@@ -173,29 +173,6 @@ func TestHandle(t *testing.T) {
 				assert.Error(t, err)
 			},
 		},
-		{
-			name:   "error on GetCombinedStatus",
-			config: testConfig,
-			prepare: func(mock *cherrypickapprovedfakes.FakeImpl) {
-				mock.GetCombinedStatusReturns(nil, errTest)
-			},
-			assert: func(mock *cherrypickapprovedfakes.FakeImpl, err error) {
-				assert.Error(t, err)
-			},
-		},
-		{
-			name:   "skip with failed tests",
-			config: testConfig,
-			prepare: func(mock *cherrypickapprovedfakes.FakeImpl) {
-				mock.GetCombinedStatusReturns(&github.CombinedStatus{
-					Statuses: []github.Status{{State: github.StatusError}},
-				}, nil)
-			},
-			assert: func(mock *cherrypickapprovedfakes.FakeImpl, err error) {
-				assert.NoError(t, err)
-				assert.EqualValues(t, 0, mock.GetIssueLabelsCallCount())
-			},
-		},
 		{
 			name:   "skip with wrong review state",
 			config: testConfig,