fix(idc): gracefully handle FEATURE_NOT_SUPPORTED in usage limits#79
Open
leecoder wants to merge 1 commit intotickernelz:masterfrom
Open
fix(idc): gracefully handle FEATURE_NOT_SUPPORTED in usage limits#79leecoder wants to merge 1 commit intotickernelz:masterfrom
leecoder wants to merge 1 commit intotickernelz:masterfrom
Conversation
Some IDC profiles do not support getUsageLimits. This change prevents the account from being penalized or failing to register when the API returns FEATURE_NOT_SUPPORTED. A placeholder email is used when the real email cannot be fetched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some IDC profiles do not support
getUsageLimits, which returns aFEATURE_NOT_SUPPORTEDerror. This caused:Changes
src/core/auth/idc-auth-method.tsusagewith safe defaults so auth can proceed even iffetchUsageLimitsfailsFEATURE_NOT_SUPPORTEDerror and log a warning instead of throwingmakePlaceholderEmailas fallback when real email is unavailablesrc/core/account/usage-tracker.tsFEATURE_NOT_SUPPORTEDto avoid penalizing the accountTesting