Fix the wasm build#792
Merged
Merged
Conversation
xlstypes.h includes sys/types.h from inside namespace xls { extern "C" {.
Once the include guard fires there, gid_t and uid_t are trapped in the xls::
namespace. Subsequent headers (e.g. unistd.h via RProgress.h) that rely on
those types being in the global namespace then fail to compile.
Same pattern and fix as the stdint.h hoist in issue #775.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
Thanks! Closes #791 which was starting to go in the usual circles again 🤪 |
jennybc
added a commit
that referenced
this pull request
May 16, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/r-universe/tidyverse/actions/runs/25782684607/job/75729150069