Fix dead links breaking the 3.23.1 build#2828
Merged
Merged
Conversation
The LINK-CHECK step validates every absolute URL against the live server and fails the build on any dead link. Address the failures: - Add static/calico-enterprise/3.23/scripts/ (switch-active-operator.sh, install-calico-windows.ps1). The versioned static dir was never created at the 3.23 cut, though tmpScriptsURL points at /calico-enterprise/3.23. - Repoint the rotted kubernetes.io Condition link to the current .../kubernetes-api/definitions/condition-v1-meta/ in network.mdx (current + version-3.23-2); the old common-definitions path 404s. - Skip-list the breadcrumb category URLs for the kubevirt and calicoctl/review pages that are new in 3.23 (linkChecker.js), mirroring the existing OSS-Calico kubevirt rule. These clear once 3.23.1 publishes. Download-artifact URLs are intentionally NOT skip-listed: a missing package on downloads.tigera.io is a real publish failure and should break the build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ctauchen
force-pushed
the
fix-deadlinks-3.23.1
branch
from
July 6, 2026 16:50
4748df0 to
1a8c52d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
LINK-CHECKbuild step fires a real network request at every absolute URL and fails the build on any dead link. This PR resolves:Genuine fix
Conditionreference inreference/resources/network.mdx(current +version-3.23-2) from the removedcommon-definitions/condition/path to the currentkubernetes-api/definitions/condition-v1-meta/(verified 200).Skip-listed pre-publish false positives (
src/utils/linkChecker.js)Breadcrumb category URLs for pages new in 3.23; they fail only because 3.23.1 isn't live on production yet and clear on publish. Mirror the existing OSS-Calico kubevirt skip:
docs.tigera.io/calico-enterprise/latest/networking/kubevirt/docs.tigera.io/calico-enterprise/latest/reference/clis/calicoctl/review/Related PRs
switch-active-operator.sh404) is handled separately againstmainin Add static/calico-enterprise/3.23/scripts/ #2831, so it deploys to production ahead of the release.downloads.tigera.ioskips are in Skip pre-publish downloads.tigera.io URLs in link check #2830.Download package/artifact URLs are intentionally left unskipped — a missing package is a real publish failure and should break the build.
🤖 Generated with Claude Code