Minimize analytics consent modal - #150
Draft
feynon wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The consent modal occupied too much of the mobile viewport and felt oversized on desktop. Its large width, padding, line height, and controls made a short consent decision visually dominate the page.
Impact
The modal now reads as a compact, unobtrusive consent prompt at both mobile and desktop sizes while remaining fully usable and scroll-safe within
100dvh.Validation
git diff --check/booksuccessfully in Next.js dev mode at 390 × 844 and 1440 × 900 viewportsnpx tsc --noEmitreaches this component but remains blocked by existing unrelated type errors elsewhere in the repository