Fix for issue #261, Access to UIImagePickerController Object - #262
Open
brt-manishp wants to merge 166 commits into
Open
Fix for issue #261, Access to UIImagePickerController Object#262brt-manishp wants to merge 166 commits into
brt-manishp wants to merge 166 commits into
Conversation
Support for detection if TLPHAsset is created from camera using picker.
# Conflicts: # Example/TLPhotoPicker.xcodeproj/project.pbxproj # Example/TLPhotoPicker/Base.lproj/Main.storyboard # TLPhotoPicker/Classes/TLCollectionTableViewCell.swift
- Remove usedPrefetch condition from willDisplay to fix off-screen cell order display - Ensure cells always show correct selection state when scrolled into view
- Fix selection order not updating for off-screen cells 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…bclassed. Update necessary dependencies to be public.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…an be subclassed. Update necessary dependencies to be public." This reverts commit 4852917.
Reverted PR #378 changes due to critical issues. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…bclassed. Update necessary dependencies to be public.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When didCaptureMediaURL is set on TLPhotosPickerViewController, captured photos and videos are written to a temp file and the URL is passed to the callback instead of being saved to the photo library. Existing behaviour is unchanged when the callback is not set. Signed-off-by: Rasmus Wøldike <rswoldike@gmail.com>
Signed-off-by: Rasmus Wøldike <rswoldike@gmail.com>
- Use info[.imageURL] with imageExportPreset .compatible to preserve EXIF/GPS metadata - Only invoke callback on successful file copy (no silent error swallowing)
Dismiss the camera picker and host TLPhotosPickerViewController before invoking didCaptureMediaURL so callers only need to present their next screen. Preserve dismiss lifecycle hooks and document the present-only callback contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In "showCamera()" there is a local variable called "picker" which I need it access to configure image picker for various use case. So I made a public optional variable of UIImagePickerController in "TLPhotosPickerConfigure" and used it in "showCamera()" with null check
Changes made are as follows in file named TLPhotosPickerViewController.swift