Support for having non-square previews + make selectCameraCell open to allow for opening custom camera without needing a custom cell - #335
Open
NickNeedsAName wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is two parts, the first (
selectCameraCell-> open) was done so I could open my own cameraView without needing a custom camera cell. I guess I can get rid of this if you really want, but it's not breaking.The second part I was pretty amazed to find lacking - all preview cells in the picker are always squares.
Simple fix (great code, easy to do) - add a cellHWAspectRatio to the config, then use that to compute height.