audit: don't allow adding/removing registries with no verification gateway

[keyleu]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @keyleu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces important pre-condition checks to the Authorization smart contract, ensuring that critical registry management operations (addRegistries and removeRegistries) can only be executed when a verificationGateway has been properly configured. This enhances the contract's robustness by preventing actions that rely on an uninitialized or invalid dependency, and new tests have been added to cover these new validations.

Highlights

• Security Enhancement: I've added a crucial validation check within the addRegistries function in Authorization.sol. This ensures that any attempt to add new registries will revert if the verificationGateway address is not properly set (i.e., it's the zero address), preventing operations on an uninitialized dependency.
• Security Enhancement: Similarly, I've implemented the same validation check in the removeRegistries function in Authorization.sol. This prevents the removal of registries if the verificationGateway is not configured, maintaining the integrity of the contract's state.
• Test Coverage: I've introduced two new unit tests in AuthorizationZK.t.sol: test_RevertWhen_AddRegistriesNoVerificationGateway and test_RevertWhen_RemoveRegistriesNoVerificationGateway. These tests explicitly verify that the addRegistries and removeRegistries functions correctly revert with the expected error message when the Authorization contract is initialized without a valid verificationGateway.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a check to ensure a verification gateway is set before adding or removing registries. Suggestions include using Solidity custom errors for gas efficiency and maintainability, and updating tests accordingly.