feat: erc7540 vault deposit flow#440
Merged
Merged
Conversation
keyleu
reviewed
Oct 1, 2025
| } | ||
|
|
||
| constructor() { | ||
| // _disableInitializers(); |
Contributor
There was a problem hiding this comment.
this should not be commented so that initialization is only through the proxy.
Contributor
Author
There was a problem hiding this comment.
done, enabled proxy in tests as well
Comment on lines
+136
to
+145
| /// Checks whether a given address is an approved operator for a controller | ||
| /// @param controller The address of the controller | ||
| /// @param operator The address of the operator to check | ||
| /// @return A boolean indicating whether the operator is approved | ||
| function isOperator( | ||
| address controller, | ||
| address operator | ||
| ) external view returns (bool) { | ||
| return operators[controller][operator]; | ||
| } |
Contributor
There was a problem hiding this comment.
This is not used right? Also the mapping is already public so there is a getter method to get values from the mapping created automatically.
If you are using it as a helper method internally should be set as internal instead of external as we are just duplicating.
Contributor
Author
There was a problem hiding this comment.
it's just for erc7540 compliance, but i just realized i didn't add tests for it so doing that now
keyleu
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an intermediate pr for the updated two-way vault design that focuses on the deposit flow.
The follow-up pr will implement the withdraw flow as well as any leftover logic relating to owner operations, storage optimizations, proxy, etc.
Putting this out here now so that it's easier to review the core logic.
new additions/changes from the previous vaults:
operator: vault now implementsIERC7540Operator, which describes the logic for users to approve other addresses (operators) to issue requests on their behalfonlyWhenSharePriceNotStalemodifier will check for the last update timestamp and revert in case the price is stale (to be discussed)