Skip to content

fix(types): add overloads for createQueue and updateQueue - #600

Merged
timgit merged 2 commits into
timgit:masterfrom
bcomnes:fix/createQueue-type-signature
Oct 3, 2025
Merged

fix(types): add overloads for createQueue and updateQueue#600
timgit merged 2 commits into
timgit:masterfrom
bcomnes:fix/createQueue-type-signature

Conversation

@bcomnes

@bcomnes bcomnes commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Added overloaded type signatures to support both calling patterns:

  • createQueue(name, options) with Omit<Queue, 'name'>
  • createQueue(options) with required name in Queue

This fixes type errors when name is passed as the first parameter, matching the actual implementation which supports both patterns.

Added overloaded type signatures to support both calling patterns:
- createQueue(name, options) with Omit<Queue, 'name'>
- createQueue(options) with required name in Queue

This fixes type errors when name is passed as the first parameter,
matching the actual implementation which supports both patterns.
@bcomnes

bcomnes commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

I added types for the still emitted 'stopped' event.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 94.589%. remained the same
when pulling 2a57ff8 on bcomnes:fix/createQueue-type-signature
into 56255b6 on timgit:master.

@timgit
timgit merged commit d6405e0 into timgit:master Oct 3, 2025
4 checks passed
@bcomnes
bcomnes deleted the fix/createQueue-type-signature branch October 8, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants