fix: add @types/react to peerDependencies for pnpm strict mode compatibility#427
Open
afurm wants to merge 1 commit intotimolins:mainfrom
Open
fix: add @types/react to peerDependencies for pnpm strict mode compatibility#427afurm wants to merge 1 commit intotimolins:mainfrom
afurm wants to merge 1 commit intotimolins:mainfrom
Conversation
…ibility Fixes timolins#426 Adds @types/react to peerDependencies since the package's .d.ts files import from react, and TypeScript resolves these types through @types/react. Without it, pnpm strict mode (hoist: false) fails with: error TS2307: Cannot find module 'react'
|
@afurm is attempting to deploy a commit to the timo's Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
@types/react: *topeerDependenciesto fix TypeScript resolution in pnpm strict mode.Problem
The package's
.d.tsfiles import fromreact:TypeScript resolves these types through
@types/react, but the package only declaredreactandreact-domas peer dependencies. This works in npm/yarn (flatnode_modules) but fails with pnpm strict mode (hoist: false):Solution
Add
@types/reacttopeerDependencies. The*version constraint matches any version that the consumer already has.Testing
Verified by adding to a project with pnpm strict mode enabled.
Fixes #426