Skip to content

restore anonymous registry pulls: #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
May 27, 2026
Merged

restore anonymous registry pulls: #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions oci2disk/image/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,20 @@ func Write(sourceImage, destinationDevice string, compressed bool, registryUsern
},
}

registryOpts := []docker.RegistryOpt{docker.WithClient(client)}
// Always install an authorizer so the resolver can handle Bearer-token
// challenges from registries like ghcr.io even for anonymous pulls. When
// credentials are provided, wire them into the auth callback; otherwise the
// authorizer performs an unauthenticated token exchange.
authorizerOpts := []docker.AuthorizerOpt{docker.WithAuthClient(client)}
if registryUsername != "" && registryPassword != "" {
log.Infof("Registry credentials provided, using authenticated pull")
authorizer := docker.NewDockerAuthorizer(
docker.WithAuthClient(client),
docker.WithAuthCreds(func(_ string) (string, string, error) {
return registryUsername, registryPassword, nil
}),
)
registryOpts = append(registryOpts, docker.WithAuthorizer(authorizer))
authorizerOpts = append(authorizerOpts, docker.WithAuthCreds(func(_ string) (string, string, error) {
return registryUsername, registryPassword, nil
}))
}
registryOpts := []docker.RegistryOpt{
docker.WithClient(client),
docker.WithAuthorizer(docker.NewDockerAuthorizer(authorizerOpts...)),
}
Comment thread
jacobweinstock marked this conversation as resolved.

resolver := docker.NewResolver(docker.ResolverOptions{
Expand Down