Skip to content

merge queue: embarking main (0847b08) and #183 together#184

Closed
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/82d1d619aa
Closed

merge queue: embarking main (0847b08) and #183 together#184
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/82d1d619aa

Conversation

@mergify

@mergify mergify Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (0847b08) and #183 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #183.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

  • all of:
  • any of [🛡 GitHub branch protection]:
    • check-success = Build (amd64, writefile)
    • check-neutral = Build (amd64, writefile)
    • check-skipped = Build (amd64, writefile)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build (amd64, archive2disk)
    • check-neutral = Build (amd64, archive2disk)
    • check-skipped = Build (amd64, archive2disk)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build (amd64, cexec)
    • check-neutral = Build (amd64, cexec)
    • check-skipped = Build (amd64, cexec)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build (amd64, grub2disk)
    • check-neutral = Build (amd64, grub2disk)
    • check-skipped = Build (amd64, grub2disk)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build (amd64, image2disk)
    • check-neutral = Build (amd64, image2disk)
    • check-skipped = Build (amd64, image2disk)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build (amd64, kexec)
    • check-neutral = Build (amd64, kexec)
    • check-skipped = Build (amd64, kexec)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build (amd64, oci2disk)
    • check-neutral = Build (amd64, oci2disk)
    • check-skipped = Build (amd64, oci2disk)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build (amd64, qemuimg2disk)
    • check-neutral = Build (amd64, qemuimg2disk)
    • check-skipped = Build (amd64, qemuimg2disk)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build (amd64, rootio)
    • check-neutral = Build (amd64, rootio)
    • check-skipped = Build (amd64, rootio)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build (amd64, slurp)
    • check-neutral = Build (amd64, slurp)
    • check-skipped = Build (amd64, slurp)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build (amd64, syslinux)
    • check-neutral = Build (amd64, syslinux)
    • check-skipped = Build (amd64, syslinux)
  • any of [🛡 GitHub branch protection]:
    • check-success = DCO
    • check-neutral = DCO
    • check-skipped = DCO

Required conditions to stay in the queue:

---
checking_base_sha: 0847b084577a4a1772762cbdac0fc00aa981f99e
previous_failed_batches: []
pull_requests:
  - number: 183
    scopes: []
scopes: []
...

jacobweinstock and others added 2 commits May 27, 2026 15:56
The resolver setup only installed an Authorizer when
registry credentials were supplied. Without an authorizer
the docker resolver has no way to answer a Bearer-token
challenge, so anonymous pulls from registries that
always challenge (e.g. ghcr.io, even for public images)
fail with 401 on the first HEAD request. The previous
code worked because docker.NewResolver synthesised a
default authorizer with nil creds, which still performs
the unauthenticated token exchange.

Always install a docker authorizer and only attach the
credential callback when both username and password are set.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@mergify mergify Bot mentioned this pull request May 27, 2026
3 tasks
@mergify mergify Bot closed this May 27, 2026
@mergify mergify Bot deleted the mergify/merge-queue/82d1d619aa branch May 27, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant