merge queue: embarking main (0847b08) and #183 together#184
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: embarking main (0847b08) and #183 together#184mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
The resolver setup only installed an Authorizer when registry credentials were supplied. Without an authorizer the docker resolver has no way to answer a Bearer-token challenge, so anonymous pulls from registries that always challenge (e.g. ghcr.io, even for public images) fail with 401 on the first HEAD request. The previous code worked because docker.NewResolver synthesised a default authorizer with nil creds, which still performs the unauthenticated token exchange. Always install a docker authorizer and only attach the credential callback when both username and password are set. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (0847b08) and #183 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #183.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:#changes-requested-reviews-by=0base=maincheck-success=Build (amd64, archive2disk)check-success=Build (amd64, cexec)check-success=Build (amd64, grub2disk)check-success=Build (amd64, image2disk)check-success=Build (amd64, kexec)check-success=Build (amd64, oci2disk)check-success=Build (amd64, qemuimg2disk)check-success=Build (amd64, rootio)check-success=Build (amd64, slurp)check-success=Build (amd64, syslinux)check-success=Build (amd64, writefile)check-success=DCOlabel!=do-not-mergeauthor=jacobweinstock#approved-reviews-by>=1check-success = Build (amd64, writefile)check-neutral = Build (amd64, writefile)check-skipped = Build (amd64, writefile)check-success = Build (amd64, archive2disk)check-neutral = Build (amd64, archive2disk)check-skipped = Build (amd64, archive2disk)check-success = Build (amd64, cexec)check-neutral = Build (amd64, cexec)check-skipped = Build (amd64, cexec)check-success = Build (amd64, grub2disk)check-neutral = Build (amd64, grub2disk)check-skipped = Build (amd64, grub2disk)check-success = Build (amd64, image2disk)check-neutral = Build (amd64, image2disk)check-skipped = Build (amd64, image2disk)check-success = Build (amd64, kexec)check-neutral = Build (amd64, kexec)check-skipped = Build (amd64, kexec)check-success = Build (amd64, oci2disk)check-neutral = Build (amd64, oci2disk)check-skipped = Build (amd64, oci2disk)check-success = Build (amd64, qemuimg2disk)check-neutral = Build (amd64, qemuimg2disk)check-skipped = Build (amd64, qemuimg2disk)check-success = Build (amd64, rootio)check-neutral = Build (amd64, rootio)check-skipped = Build (amd64, rootio)check-success = Build (amd64, slurp)check-neutral = Build (amd64, slurp)check-skipped = Build (amd64, slurp)check-success = Build (amd64, syslinux)check-neutral = Build (amd64, syslinux)check-skipped = Build (amd64, syslinux)check-success = DCOcheck-neutral = DCOcheck-skipped = DCORequired conditions to stay in the queue:
label=ready-to-merge#changes-requested-reviews-by=0base=maincheck-success=Build (amd64, archive2disk)check-success=Build (amd64, cexec)check-success=Build (amd64, grub2disk)check-success=Build (amd64, image2disk)check-success=Build (amd64, kexec)check-success=Build (amd64, oci2disk)check-success=Build (amd64, qemuimg2disk)check-success=Build (amd64, rootio)check-success=Build (amd64, slurp)check-success=Build (amd64, syslinux)check-success=Build (amd64, writefile)check-success=DCOlabel!=do-not-mergeauthor=jacobweinstock#approved-reviews-by>=1check-success = Build (amd64, writefile)check-neutral = Build (amd64, writefile)check-skipped = Build (amd64, writefile)check-success = Build (amd64, archive2disk)check-neutral = Build (amd64, archive2disk)check-skipped = Build (amd64, archive2disk)check-success = Build (amd64, cexec)check-neutral = Build (amd64, cexec)check-skipped = Build (amd64, cexec)check-success = Build (amd64, grub2disk)check-neutral = Build (amd64, grub2disk)check-skipped = Build (amd64, grub2disk)check-success = Build (amd64, image2disk)check-neutral = Build (amd64, image2disk)check-skipped = Build (amd64, image2disk)check-success = Build (amd64, kexec)check-neutral = Build (amd64, kexec)check-skipped = Build (amd64, kexec)check-success = Build (amd64, oci2disk)check-neutral = Build (amd64, oci2disk)check-skipped = Build (amd64, oci2disk)check-success = Build (amd64, qemuimg2disk)check-neutral = Build (amd64, qemuimg2disk)check-skipped = Build (amd64, qemuimg2disk)check-success = Build (amd64, rootio)check-neutral = Build (amd64, rootio)check-skipped = Build (amd64, rootio)check-success = Build (amd64, slurp)check-neutral = Build (amd64, slurp)check-skipped = Build (amd64, slurp)check-success = Build (amd64, syslinux)check-neutral = Build (amd64, syslinux)check-skipped = Build (amd64, syslinux)check-success = DCOcheck-neutral = DCOcheck-skipped = DCO