fix(core): preserve transcript commitment order - #1179
Open
Wondertan wants to merge 1 commit into
Open
Conversation
The SDK correlates returned hash openings with the input Commit by index. Preserve builder insertion order while continuing to suppress duplicate commitments. Assisted-by: GPT-5 Signed-off-by: Wondertan <hlibwondertan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
RevealOutputpromises that each opening matches the inputCommitby index, andSdkProver::revealadds sent ranges followed by received ranges to the commitment builder. Before this fix, the builder stored those requests in aHashSetand emitted its arbitrary iteration order.build_reveal_outputthen preserves that received order within each direction without remapping by range.With multiple commitments in one direction, callers could therefore associate an opening with the wrong plaintext range.
Tests
cargo test -p tlsn-corecargo test -p tlsn-sdk-core --lib