Document the unanswered-commit case in transactional persistence - #26
Open
tobiajo wants to merge 1 commit into
Open
Document the unanswered-commit case in transactional persistence#26tobiajo wants to merge 1 commit into
tobiajo wants to merge 1 commit into
Conversation
tobiajo
force-pushed
the
tj/pin-ambiguous-commit-contract
branch
2 times, most recently
from
August 4, 2026 18:37
d7bea94 to
da32918
Compare
The transactional mode's one failure that is not a rejection: an unanswered commit. If `commitTransaction` times out client-side it surfaces as the client's `TimeoutException`, not the `CommitFailedException` of a fenced write, and the broker may have committed anyway. Nothing is lost either way: the input offset rides the same transaction, so snapshot and offset commit together or not at all. The flush does not retry it - legal per the client contract, but each attempt would block up to `max.block.ms` inside the poll cycle, risking a silent eviction at `max.poll.interval.ms` - and `abortTransaction` throws rather than aborting while a commit is unresolved, so the producer is unusable until rebuilt: only a retry of that same commit acks the client's pending transition, and nothing clears it in the background. Under the default `ignorePersistErrors = false` the failure tears the flow down and the new producer's `initTransactions` settles the transaction. Under `ignorePersistErrors = true` it is swallowed instead, so the partition stops persisting AND stops advancing offsets until the flow restarts - at the next rebalance, or sooner if a later offset commit through the spent producer crashes it. Documented as a bullet in the transactional section, alongside the other failure mode it resembles (a recovery read that fails loudly), rather than under rejected writes - it is not one. GroupCommitSpec pins the kafka-flow half: the timeout surfaces unchanged, kafka-flow never retries the commit, and the cleanup abort is attempted without its own outcome replacing the timeout. No production code changes. The client contract and a measurement of it are pinned as ext(K16) in the verification research corpus; that harness is not checked in, since it pins a kafka-clients contract rather than kafka-flow behavior.
tobiajo
force-pushed
the
tj/pin-ambiguous-commit-contract
branch
from
August 4, 2026 18:56
da32918 to
0c11d7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the transactional mode's one failure that is not a rejection: an unanswered commit. If
commitTransactiontimes out client-side it surfaces as the client'sTimeoutException, not theCommitFailedExceptionof a fenced write, and the broker may have committed anyway.max.block.msinside the poll cycle, risking a silent eviction atmax.poll.interval.ms— andabortTransactionthrows rather than aborting while a commit is unresolved (commitBatchalready discards that throw). The producer is unusable until rebuilt: only a retry of that same commit acks the client's pending transition, and nothing clears it in the background.ignorePersistErrors = falsethe failure tears the flow down and the new producer'sinitTransactionssettles the transaction. UnderignorePersistErrors = trueit is swallowed instead, so the partition stops persisting and stops advancing offsets until the flow restarts — at the next rebalance, or sooner if a later offset commit through the spent producer crashes it. Frozen and self-consistent, not corrupted.Documented as a bullet in the transactional section, next to the failure mode it most resembles (a recovery read that fails loudly), rather than under rejected writes — it is not one.
GroupCommitSpecpins the kafka-flow half: the timeout surfaces unchanged, kafka-flow never retries the commit, and the cleanup abort is attempted without its own outcome replacing the timeout. No production code changes.The client contract, and a measurement of it against a broker paused mid-commit, are pinned as
ext(K16)in the research corpus (#835). That harness is not checked in: it pins a kafka-clients contract rather than kafka-flow behavior.