Skip to content

session replay sample rate 수치 조정#216

Merged
baekteun merged 1 commit intomasterfrom
feature/session-replay-sample-rate
Mar 29, 2026
Merged

session replay sample rate 수치 조정#216
baekteun merged 1 commit intomasterfrom
feature/session-replay-sample-rate

Conversation

@baekteun
Copy link
Copy Markdown
Member

💡 개요

session replay sample rate 수치 조정

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8030e730-5d45-4125-b615-39ff0a5ef2e2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/session-replay-sample-rate
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

🛠️ 이슈와 PR의 Labels 동기화를 스킵했어요.

@github-actions
Copy link
Copy Markdown
Contributor

✅ PR의 Assign 자동 지정을 성공했어요!

@baekteun

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 Pull Request는 iOS 애플리케이션의 세션 리플레이 샘플링 비율을 조정하여 데이터 수집 효율성을 개선하는 것을 목표로 합니다. 또한, 애플리케이션의 버전 및 빌드 번호를 최신 상태로 업데이트했습니다.

Highlights

  • 세션 리플레이 샘플링 비율 조정: iOS 환경에서 AmplitudeSwiftSessionReplayPlugin의 샘플링 비율을 1.0에서 0.03으로 변경하여 세션 리플레이 데이터 수집량을 줄였습니다.
  • 애플리케이션 버전 업데이트: Info.plist 파일에서 앱의 단축 버전 문자열(CFBundleShortVersionString)을 12.3에서 12.4로, 번들 버전(CFBundleVersion)을 89에서 90으로 업데이트했습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Projects/App/iOS/Support/Info.plist
    • CFBundleShortVersionString을 12.3에서 12.4로 업데이트했습니다.
    • CFBundleVersion을 89에서 90으로 업데이트했습니다.
  • Projects/Shared/TWLog/Sources/TWLog.swift
    • AmplitudeSwiftSessionReplayPlugin의 sampleRate를 1.0에서 0.03으로 변경했습니다.
Activity
  • 이 Pull Request에 대한 특정 활동(댓글, 검토 등)은 관찰되지 않았습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

안녕하세요. 세션 리플레이 샘플링 비율을 조정하는 변경사항을 잘 확인했습니다. TWLog.swift 파일에서 하드코딩된 숫자(매직 넘버)를 상수로 추출하여 코드의 가독성과 유지보수성을 개선하는 것을 제안합니다. 자세한 내용은 아래 주석을 참고해주세요.


#if os(iOS)
amplitude.add(plugin: AmplitudeSwiftSessionReplayPlugin(sampleRate: 1.0))
amplitude.add(plugin: AmplitudeSwiftSessionReplayPlugin(sampleRate: 0.03))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

매직 넘버 0.03을 직접 사용하는 것보다 상수로 정의하여 코드의 가독성과 유지보수성을 높이는 것이 좋습니다. 이렇게 하면 나중에 값을 변경하기가 더 쉬워집니다.

        let sessionReplaySampleRate = 0.03
        amplitude.add(plugin: AmplitudeSwiftSessionReplayPlugin(sampleRate: sessionReplaySampleRate))

Base automatically changed from feature/on-visible-modify-timetable-when-save to master March 29, 2026 13:09
@baekteun baekteun merged commit 77aff82 into master Mar 29, 2026
3 checks passed
@baekteun baekteun deleted the feature/session-replay-sample-rate branch March 29, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant