feat(Renderable) Add a new Value variant: Renderable#133
Open
johnhurt wants to merge 6 commits intotokio-rs:masterfrom
Open
feat(Renderable) Add a new Value variant: Renderable#133johnhurt wants to merge 6 commits intotokio-rs:masterfrom
Value variant: Renderable#133johnhurt wants to merge 6 commits intotokio-rs:masterfrom
Conversation
|
is there any progress here? this would be incredibly helpful for custom domain specific types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a method of representing a value only though its
DisplayorDebugimplementation.There is some discussion in #43 about making 2 different variants for
DisplayandDebug, but that presented a problem becauseValuableneeds to implementDebug, but& dyn Displaydoesn’t. Adding a new trait likeDisplayableto wrap& dyn Displayseems a little wasteful 😜This method wraps both would-be variants
DisplayandDebugin an enumRenderableand adds a new variant of the same name. The next step is to add#[display]and#[debug]derive annotations to allow struct fields to be included as theirDisplayorDebugimplementations instead of actual values (as discussed in #131)