Conversation
Collaborator
|
This would be totally fine except that someone would need to implement support for that on desktop. Which is not very likely to happen :( |
Member
|
I would rather like build tooling compiling a standalone js file - that wouldnt even need support in any app, be it desktop or android. I started work on that,see my party like it's 2015 PR (kinda sad i havent found time to progress on that ever since) |
The Tidal API now checks for a "clientVersion" string when processing logins, if the clientVersion is not included in the request the API will generate a 403 and not return a response back to the user. Added the current version at the time of writing (2.2.1--7). Not sure if the actual version number matters but if it does it may be possible to query the API for the current version and it might be worth the time to research this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to improve js performance I suggest that we only load libraries if the js plugin actually requires it. E.g right now we are always loading the entire cryptojs lib for every single webview. To fix this a simple "lib" array should be added to the metadata.json:
This would also allow proper versioning of js libraries.
Of course this has to be supported by tomahawk-desktop first before we can merge this PR.