Skip to content

Add a brand icon for the integration - #447

Merged
tomer-w merged 2 commits into
tomer-w:mainfrom
pos-ei-don:add-brand-icon
Jul 7, 2026
Merged

Add a brand icon for the integration#447
tomer-w merged 2 commits into
tomer-w:mainfrom
pos-ei-don:add-brand-icon

Conversation

@pos-ei-don

@pos-ei-don pos-ei-don commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi 👋

In the HA integration list there's a view that was showing an empty placeholder icon — no icon at all — even though there's an entry in home-assistant/brands. Since HA 2026.3, the Brands Proxy API serves custom-integration icons from a local brand/ folder inside the integration first, before falling back to the central brands CDN. A submission to the brands repo was rejected pointing to this new approach.

This PR ships the official Victron icons already in home-assistant/brands/custom_integrations/victron_mqtt into the integration's own brand/ folder — same artwork, no new design, fixes the empty-placeholder view.

  • icon.png — 256×256, from the brands repo
  • icon@2x.png — 512×512, from the brands repo

@pos-ei-don
Add a brand icon for the integration
40c90b3 
Serve a brand icon via the Brands Proxy API by shipping it in
custom_components/victron_mqtt/brand/ (icon.png 256x256, icon@2x.png 512x512).
Original, neutral energy/MQTT motif — not the Victron trademark.
@tomer-w

tomer-w commented Jun 29, 2026

Copy link
Copy Markdown
Owner

@pos-ei-don , thanks for caring for the integration!! I really appreciate it.
I am confused. At least historically the icons came from the HA brands repository and I added ours here: https://github.com/home-assistant/brands/tree/master/custom_integrations/victron_mqtt
Do you say this is not getting used anymore and we need to add some files locally to the integration folder? I didnt look into it for long time.

pos-ei-don
brand: use official Victron icons from home-assistant/brands
610bd47 
Replace AI-generated icons with the existing official Victron artwork
from home-assistant/brands/custom_integrations/victron_mqtt.

Since HA 2026.3 the Brands Proxy API serves icons from the integration's
local brand/ folder first, falling back to the central brands CDN.
Shipping the icons locally fixes the empty-placeholder view in the HA
integration list without changing the visual branding.
@pos-ei-don

pos-ei-don commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Small update: I've replaced the AI-generated icon in this PR with the official Victron icons already in the home-assistant/brands repository (your existing icon.png / icon@2x.png from there).

Context for why this PR exists: in the HA integration list there's a view where no icon was showing at all — just an empty placeholder — even though your brands-repo entry is there. Since HA 2026.3 serves custom-integration icons via the Brands Proxy API (local brand/ folder takes precedence), shipping the icon locally fixes that view. The brands repo submission we tried was rejected pointing to this new approach.

So this PR now just brings your existing official Victron branding into the integration's own brand/ folder — no new/AI artwork, same icons you already have in the brands repo.

@tomer-w
tomer-w merged commit 8fd9508 into tomer-w:main Jul 7, 2026
5 checks passed
@tomer-w

tomer-w commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Thanks for your help @pos-ei-don !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pos-ei-don @tomer-w