revert: remove display_id (added in #106, no longer needed) - #110
Merged
Conversation
The display_id property on ParsedTopic and Metric was introduced to support de-duplicated entity_ids in ha-victron-mqtt's complex naming path. The integration PR that consumed it was redesigned to simply drop the explicit self.entity_id assignment instead, so HA derives entity_ids from names — making display_id unused. Reverts the three-file change from tomer-w#106.
Contributor
✅ Static Tests passed |
tomer-w
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
display_idproperty onParsedTopicandMetricwas introduced in #106 to support de-duplicated entity_ids in the integration's complex naming path.The integration PR that consumed it (ha-victron-mqtt#448) was redesigned: instead of using
display_idas a cleanerentity_idsuggestion, it now simply drops the explicitself.entity_id = ...assignment so HA derives entity_ids from names — the same way simple naming already works.With no consumer,
display_idis unused. Reverting as requested in the ha-victron-mqtt#448 review thread.Changes: pure deletion, no logic changed — removes
display_idfromParsedTopic(data_classes.py),Metric.__init__+ property (metric.py), and the two call sites indevice.py.