[HOTFIX] PM-5653 leaderboard calculations - #122
Closed
vas3a wants to merge 2 commits into
Closed
Conversation
… into PM-5653_leaderboard-calculations
There was a problem hiding this comment.
Pull request overview
Hotfix to adjust leaderboard eligibility so only submissions with a passing review count, and to update dashboard “member payment” reports to include projected (non-cancelled) payments based on payment creation date rather than paid date.
Changes:
- Leaderboard: incorporate
reviewSummation.isPassinginto the “passes review” check, with a score-threshold fallback whenisPassingis unavailable. - Dashboard SQL + tests: treat payments as “non-cancelled” and use
created_at AS activity_at(removing reliance ondate_paid/PAIDstatus). - Docs: update dashboard definitions in README to reflect projected/non-cancelled payment semantics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/reports/dashboard/dashboard-reports.sql.spec.ts | Updates SQL expectations to assert projected/non-cancelled payment semantics and activity_at usage. |
| sql/reports/topcoder/leaderboard-generic.sql | Uses reviewSummation.isPassing to ensure only passing-review submissions are counted for leaderboard. |
| sql/reports/dashboard/member-payment-by-month.sql | Switches member-payment aggregation to created_at and includes non-cancelled payment statuses. |
| sql/reports/dashboard/member-payment-by-customer.sql | Aligns customer-split payment aggregation with projected/non-cancelled + created_at semantics. |
| README.md | Updates dashboard metric definitions to match the revised payment logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
26
to
30
Comment on lines
29
to
33
Comment on lines
41
to
45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check review is passed for all submissions that count towards leaderboard