Skip to content

MM leaderboard - provisional data fix - #136

Merged
vas3a merged 1 commit into
developfrom
HOTFIX_MM-leaderboard-provisional
Aug 14, 2026
Merged

MM leaderboard - provisional data fix#136
vas3a merged 1 commit into
developfrom
HOTFIX_MM-leaderboard-provisional

Conversation

@vas3a

@vas3a vas3a commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

This pull request significantly enhances the marathon match leaderboard SQL and the related TypeScript service to provide more accurate, detailed, and web-compatible leaderboard data. The changes improve how scores are calculated and displayed, add richer member information, and ensure that only valid review types contribute to leaderboard results.

Leaderboard SQL improvements:

  • Added a filter to exclude automated scan review types (e.g., AV Scan, SonarQube Review, Virus Scan) from contributing to leaderboard scores, ensuring only relevant reviews are considered.
  • Improved score calculation logic to distinguish between final and provisional results, including new logic to determine when a match is "complete" and should display final scores.
  • Enhanced member data selection to include name, country, photo URL, rating, and rating color, and adjusted output formatting for scores and ranks to match legacy and web display requirements. [1] [2]

TypeScript types and service updates:

  • Expanded the LeaderboardMmRow type and introduced new types (LeaderboardMmEntry, LeaderboardMmMemberInfo) to better mirror the frontend leaderboard data structure and support richer member information.
  • Refactored the leaderboard data processing in the service to use the new types, ensure numeric fields are properly typed, and populate member details with accurate information from the SQL results, including rating and photo URL where available.

@vas3a
vas3a requested a review from kkartunov August 14, 2026 09:34
@vas3a
vas3a merged commit 18941b2 into develop Aug 14, 2026
5 checks passed
@vas3a
vas3a deleted the HOTFIX_MM-leaderboard-provisional branch August 14, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants