Restrict the accepted file types in the browser#273
Merged
Conversation
Previously the `FileInput` widget allowed all file types, which meant the user could select *any* file and then only find out it's not accepted after uploading. This ensures the `FileInput` only accepts the listed file extensions _or_ in the absence of file extensions, restricts to audio/video files as appropriate.
Contributor
Author
|
Looks like the Python 3.9 tests failed because of the union operator in type hints. These didn't fail locally for me when running |
zerolab
approved these changes
Dec 29, 2025
| """Returns the specified extensions in a format usable in the `accept=""` attribute of a `FileInput` widget. | ||
| This assumes the list of extensions are the bare extensions e.g., `["mp4", "webm"]` and prefixes each extension with | ||
| a ".". | ||
| """ |
Member
There was a problem hiding this comment.
non-blocking suggestion: add a link to https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/file#unique_file_type_specifiers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
FileInputwidget allowed all file types, which meant the user could select any file and then only find out it's not accepted after uploading. This ensures theFileInputonly accepts the listed file extensions or in the absence of file extensions, restricts to audio/video files as appropriate.While https://github.com/torchbox/wagtailmedia/pull/140/files handled server side validation, this complements that work by restricting the file types on the client side.