fix(lottie): forward native ref while preserving imperative methods#272
Merged
fix(lottie): forward native ref while preserving imperative methods#272
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: a6f57b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
heecheolman
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This updates the ref handling in
packages/ lottie/src/GraniteLottieView.tsx.Previously,
forwardRefexposed an imperativehandle object with only
play,pause,resume, andreset.That meant the ref was not the actual native
component instance, which could break usage
patterns that expect a native view ref.
This change:
NativeGraniteLottieViewinstanceplay/pause/resume/ resetmethods by attaching them to thatinstance
consistently, including cleanup on unmount
Why
The previous implementation supported the
imperative Lottie API, but it did not preserve
native ref compatibility.
This change keeps the current control API
intact while making the forwarded ref behave
like a native component ref.