Skip to content

fix(plugin): move marketplace.json to repo root so GitHub install works#375

Merged
kimyouknow merged 1 commit intomainfrom
fix/plugin-marketplace-root-location
Apr 21, 2026
Merged

fix(plugin): move marketplace.json to repo root so GitHub install works#375
kimyouknow merged 1 commit intomainfrom
fix/plugin-marketplace-root-location

Conversation

@kimyouknow
Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #374. The plugin is still not installable via the documented GitHub URL flow because .claude-plugin/marketplace.json lives under packages/plugin/, not at the repo root. claude plugin marketplace add always looks for the manifest at <repo-root>/.claude-plugin/marketplace.json--sparse only limits checkout scope, not the manifest lookup path.

Reproduction (on current main)

$ claude plugin marketplace add https://github.com/toss/react-simplikit \
    --sparse packages/plugin
✘ Failed to add marketplace: Marketplace file not found at
  <tempdir>/.claude-plugin/marketplace.json

Changes

File Action
.claude-plugin/marketplace.json (new at repo root) Created — points source: "./packages/plugin" at the plugin
packages/plugin/.claude-plugin/marketplace.json Deleted — moved to root
packages/plugin/README.md Updated install command to --sparse .claude-plugin packages/plugin
packages/plugin/.claude-plugin/plugin.json Untouched — plugin identity still lives with the plugin

Monorepo pattern

This matches the canonical monorepo marketplace layout:

<repo-root>/
├── .claude-plugin/marketplace.json      ← catalog (root)
└── packages/plugin/
    └── .claude-plugin/plugin.json       ← plugin identity (co-located)

Verified locally

Step Command Result
1 claude plugin validate . ✅ Passed
2 claude plugin marketplace add <repo-root> --scope local ✅ Added
3 claude plugin install react-design-philosophy@react-design-philosophy ✅ Installed v0.1.0, enabled

(Local path install mirrors the post-clone state, so this proves the real install flow will work once merged.)

Test plan

  • After merge, run the README command from a fresh directory against the public repo
  • Confirm plugin shows up in claude plugin list with status enabled

Follow-up to #374. The nested location
(packages/plugin/.claude-plugin/marketplace.json) still prevented the
GitHub-URL install flow because the CLI always looks for
'<repo-root>/.claude-plugin/marketplace.json' — '--sparse' limits
checkout scope but does not change the manifest lookup path.

Evidence of the remaining bug after #374:

  $ claude plugin marketplace add https://github.com/toss/react-simplikit \
      --sparse packages/plugin
  ✘ Failed to add marketplace: Marketplace file not found at
    <temp>/.claude-plugin/marketplace.json

Changes:
- Create .claude-plugin/marketplace.json at the repo root with
  'source': './packages/plugin' pointing at the plugin
- Delete the redundant packages/plugin/.claude-plugin/marketplace.json
- Update the README install command to sparse-checkout both the
  root manifest and the plugin directory:
    --sparse .claude-plugin packages/plugin

Verified locally (using the repo-root path, which mirrors what the
clone looks like after merge):

  claude plugin validate .                               → ✓ Passed
  claude plugin marketplace add <repo-root> --scope local → ✓ Added
  claude plugin install react-design-philosophy@...       → ✓ Installed, enabled
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

⚠️ No Changeset found

Latest commit: 42d9f73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kimyouknow kimyouknow marked this pull request as ready for review April 21, 2026 14:50
@kimyouknow kimyouknow requested a review from zztnrudzz13 as a code owner April 21, 2026 14:50
@github-actions
Copy link
Copy Markdown
Contributor

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@kimyouknow kimyouknow merged commit 9e8e0ea into main Apr 21, 2026
11 checks passed
@kimyouknow kimyouknow deleted the fix/plugin-marketplace-root-location branch April 21, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant