Skip to content
This repository was archived by the owner on Dec 18, 2025. It is now read-only.

feat(@toss/react): enhance Separated component#508

Open
metacode22 wants to merge 5 commits intotoss:mainfrom
metacode22:feat/enhance-separated
Open

feat(@toss/react): enhance Separated component#508
metacode22 wants to merge 5 commits intotoss:mainfrom
metacode22:feat/enhance-separated

Conversation

@metacode22
Copy link
Copy Markdown

@metacode22 metacode22 commented Sep 2, 2024

Overview

I'm really enjoying using this Separated component. And I've thought of a few improvements.

  • Added first and last props to include separators at the beginning and end. dc41563
  • Preserved child element keys instead of replacing them with indexes. 67851af
  • Removed isValidElement filtering to support all ReactNode types. fa3e052
  • Added test code and documentation for these changes. 8666ba4 397626a

I hope you like it. Let me know if you'd like any adjustments. Thank you!

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 2, 2024

@metacode22 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant