feat(react): Convert non-Error objects to Error instances in ErrorBoundary by Copilot · Pull Request #1786 · toss/suspensive

Copilot · 2025-10-15T08:51:59Z

Original prompt

This section details on the original issue you should resolve

<issue_title>[Feature]: If non error object thrown from children, ErrorBoundary should assert it as Error object in runtime</issue_title>
<issue_description>### Package Scope

@suspensive/react

Description

If non error object thrown from children, ErrorBoundary should assert it as Error object in runtime

Possible Solution

No response

etc.

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #1785

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

vercel · 2025-10-15T08:52:03Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Updated (UTC)
suspensive-next-streaming-react-query	Error	Mar 30, 2026 2:31pm
v2.suspensive.org	Error	Mar 30, 2026 2:31pm
v3.suspensive.org	Error	Mar 30, 2026 2:31pm
visualization.suspensive.org	Error	Mar 30, 2026 2:31pm

changeset-bot · 2025-10-15T08:52:03Z

⚠️ No Changeset found

Latest commit: 7f72a40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

manudeli · 2025-10-15T08:53:21Z

@copilot ref: https://github.com/getsentry/sentry-javascript/blob/develop/packages/react/src/error.ts#L55-L71

coauthors · 2025-10-15T08:53:24Z

People can be co-author:

Candidate	Reasons	Count	Add this as commit message
@Copilot	#1786 (comment) #1786	2	`Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>`
@manudeli	#1786 (comment) #1786 (comment)	2	`Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>`

Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>

Copilot · 2025-10-15T09:22:14Z

@copilot ref: https://github.com/getsentry/sentry-javascript/blob/develop/packages/react/src/error.ts#L55-L71

Updated the implementation to follow Sentry's approach. Changed type signatures for getDerivedStateFromError and componentDidCatch to accept any type instead of Error, acknowledging that these methods can be invoked with non-error objects. Added comments referencing the Sentry implementation and GitHub issue #6167. (commit: short hash will be in next message)

@copilot ref: https://github.com/getsentry/sentry-javascript/blob/develop/packages/react/src/error.ts#L55-L71

Updated the implementation to follow Sentry's approach. Changed type signatures for getDerivedStateFromError and componentDidCatch to accept any type instead of Error, acknowledging that these methods can be invoked with non-error objects. Added comments referencing the Sentry implementation and GitHub issue #6167. (109a5c0)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

dummyjson.com
- Triggering command: /usr/local/bin/node /home/REDACTED/work/suspensive/suspensive/node_modules/.pnpm/next@15.5.3_@babel+core@7.28.4_react-dom@19.1.1_react@19.1.1__react@19.1.1/node_modules/next/dist/compiled/jest-worker/processChild.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

manudeli · 2026-03-30T14:18:07Z

@copilot rebase

Copilot

Pull request overview

Updates @suspensive/react’s ErrorBoundary to normalize non-Error thrown values into real Error instances so fallback rendering and onError callbacks consistently receive an Error.

Changes:

Added a convertToError helper and applied it in getDerivedStateFromError and componentDidCatch.
Added tests covering conversion behavior for null, strings, numbers, and objects (both for fallback props and onError).
Updated an example tsconfig.tsbuildinfo file (TypeScript version metadata change).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
packages/react/src/ErrorBoundary.tsx	Adds `convertToError` and normalizes error values passed through boundary lifecycles.
packages/react/src/ErrorBoundary.spec.tsx	Adds test coverage ensuring fallback/onError receive `Error` instances for non-Error throws.
examples/vite-react-18-suspense-prerender-siblings-problem/tsconfig.tsbuildinfo	Updates generated build-info metadata (TypeScript version).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-30T14:23:07Z

+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  static getDerivedStateFromError(error: any): ErrorBoundaryState {
+    return { isError: true, error: convertToError(error) }
  }


getDerivedStateFromError is using any with an eslint disable. Since the method body immediately normalizes via convertToError, you can keep the React-typed signature (error: Error) or use unknown to avoid any and retain type-safety without suppressing the lint rule.

Copilot · 2026-03-30T14:23:08Z

+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  componentDidCatch(error: any, info: ErrorInfo) {


componentDidCatch is also typed as any with a lint suppression. Consider using the standard React signature (error: Error) or unknown, and then normalize with convertToError, so callers of onError remain strongly typed and you can drop the eslint disable.

Suggested change

// eslint-disable-next-line @typescript-eslint/no-explicit-any

componentDidCatch(error: any, info: ErrorInfo) {

componentDidCatch(error: unknown, info: ErrorInfo) {

Copilot · 2026-03-30T14:23:08Z

@@ -1 +1 @@
-{"root":["./src/App.tsx","./src/main.tsx","./src/vite-env.d.ts","./vite.config.ts"],"version":"5.8.3"}
+{"root":["./src/App.tsx","./src/main.tsx","./src/vite-env.d.ts","./vite.config.ts"],"version":"5.9.2"}


tsconfig.tsbuildinfo appears to be a generated build artifact, and this change is only updating the embedded TypeScript version (5.8.3 → 5.9.2) without any related source changes. It should typically be reverted/removed from the PR to avoid noisy diffs tied to local tooling versions.

Suggested change

{"root":["./src/App.tsx","./src/main.tsx","./src/vite-env.d.ts","./vite.config.ts"],"version":"5.9.2"}

{"root":["./src/App.tsx","./src/main.tsx","./src/vite-env.d.ts","./vite.config.ts"],"version":"5.8.3"}

…ed errors Agent-Logs-Url: https://github.com/toss/suspensive/sessions/756980dc-448c-442f-ab4c-ac285ee7b39e

Copilot · 2026-03-30T14:30:53Z

@copilot rebase

Rebased onto latest origin/main in commit 7f72a40. Also improved convertToError to use Object.prototype.toString checks (following Sentry's approach) so that transpiled Error subclasses with broken prototype chains (like ZodError in Zod v4) are correctly preserved as-is rather than being converted to plain Error instances.

Initial plan

eecd9a2

Copilot AI assigned Copilot and manudeli Oct 15, 2025

Copilot started work on behalf of manudeli October 15, 2025 08:52 View session

vercel bot deployed to Preview – v3.suspensive.org October 15, 2025 08:52 View deployment

vercel bot deployed to Preview – visualization.suspensive.org October 15, 2025 08:53 View deployment

vercel bot deployed to Preview – v2.suspensive.org October 15, 2025 08:56 View deployment

Initial exploration and analysis of ErrorBoundary non-Error handling

e381c6d

Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>

vercel bot deployed to Preview – v2.suspensive.org October 15, 2025 09:04 View deployment

vercel bot deployed to Preview – visualization.suspensive.org October 15, 2025 09:05 View deployment

Convert non-Error objects to Error instances in ErrorBoundary

7e6204f

Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>

vercel bot deployed to Preview – visualization.suspensive.org October 15, 2025 09:10 View deployment

Also convert non-Error objects in componentDidCatch for onError callback

a779664

Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix ErrorBoundary to assert non-error objects as Error~~ feat(react): Convert non-Error objects to Error instances in ErrorBoundary Oct 15, 2025

Copilot AI requested a review from manudeli October 15, 2025 09:13

Copilot finished work on behalf of manudeli October 15, 2025 09:13

Copilot started work on behalf of manudeli October 15, 2025 09:13 View session

vercel bot deployed to Preview – v3.suspensive.org October 15, 2025 09:16 View deployment

vercel bot deployed to Preview – visualization.suspensive.org October 15, 2025 09:18 View deployment

vercel bot deployed to Preview – v2.suspensive.org October 15, 2025 09:19 View deployment

Accept any type for error parameters following Sentry's approach

109a5c0

Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>

Copilot finished work on behalf of manudeli October 15, 2025 09:23

vercel bot deployed to Preview – v2.suspensive.org October 15, 2025 09:24 View deployment

vercel bot deployed to Preview – v3.suspensive.org October 15, 2025 09:27 View deployment

vercel bot deployed to Preview – visualization.suspensive.org October 15, 2025 09:28 View deployment

manudeli requested a review from Copilot March 30, 2026 14:18

Copilot started work on behalf of manudeli March 30, 2026 14:18 View session

Copilot started reviewing on behalf of manudeli March 30, 2026 14:18 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

rebase: sync with latest main and improve convertToError for transpil…

7f72a40

…ed errors Agent-Logs-Url: https://github.com/toss/suspensive/sessions/756980dc-448c-442f-ab4c-ac285ee7b39e

vercel bot had a problem deploying to Preview – visualization.suspensive.org March 30, 2026 14:31 Failure

vercel bot had a problem deploying to Preview – suspensive-next-streaming-react-query March 30, 2026 14:31 Failure

vercel bot had a problem deploying to Preview – v3.suspensive.org March 30, 2026 14:31 Failure

vercel bot had a problem deploying to Preview – v2.suspensive.org March 30, 2026 14:31 Failure

Copilot finished work on behalf of manudeli March 30, 2026 14:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(react): Convert non-Error objects to Error instances in ErrorBoundary#1786

feat(react): Convert non-Error objects to Error instances in ErrorBoundary#1786
Copilot wants to merge 6 commits intomainfrom
copilot/assert-error-object-in-error-boundary

Copilot AI commented Oct 15, 2025 •

edited

Loading

Uh oh!

vercel bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

manudeli commented Oct 15, 2025

Uh oh!

coauthors bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

Copilot AI commented Oct 15, 2025 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

manudeli commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// eslint-disable-next-line @typescript-eslint/no-explicit-any
		componentDidCatch(error: any, info: ErrorInfo) {

	// eslint-disable-next-line @typescript-eslint/no-explicit-any
	componentDidCatch(error: any, info: ErrorInfo) {
	componentDidCatch(error: unknown, info: ErrorInfo) {

		@@ -1 +1 @@
		{"root":["./src/App.tsx","./src/main.tsx","./src/vite-env.d.ts","./vite.config.ts"],"version":"5.8.3"} No newline at end of file
		{"root":["./src/App.tsx","./src/main.tsx","./src/vite-env.d.ts","./vite.config.ts"],"version":"5.9.2"} No newline at end of file

Conversation

Copilot AI commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Possible Solution

etc.

Comments on the Issue (you are @copilot in this section)

Uh oh!

vercel bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

manudeli commented Oct 15, 2025

Uh oh!

coauthors bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

People can be co-author:

Uh oh!

Copilot AI commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

manudeli commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Oct 15, 2025 •

edited

Loading

vercel bot commented Oct 15, 2025 •

edited

Loading

changeset-bot bot commented Oct 15, 2025 •

edited

Loading

coauthors bot commented Oct 15, 2025 •

edited

Loading

Copilot AI commented Oct 15, 2025 •

edited

Loading