Skip to content

fix(suspensive.org/Sandpack): exclude custom props from 'SandpackPreview' spread to prevent DOM warnings#1953

Open
sukvvon wants to merge 1 commit intotoss:mainfrom
sukvvon:fix/sandpack-custom-preset-dom-props
Open

fix(suspensive.org/Sandpack): exclude custom props from 'SandpackPreview' spread to prevent DOM warnings#1953
sukvvon wants to merge 1 commit intotoss:mainfrom
sukvvon:fix/sandpack-custom-preset-dom-props

Conversation

@sukvvon
Copy link
Copy Markdown
Contributor

@sukvvon sukvvon commented Apr 14, 2026

Overview

  • Destructure custom props (layout, showConsole, showConsoleButton) from previewOptions before spreading to SandpackPreview
  • These props are not part of PreviewProps but were passed to the DOM via {...props.previewOptions}, causing React warnings:
    • showConsoleButton prop on a DOM element
    • showConsole prop on a DOM element

Screenshot

AS-IS

image image image

TO-BE

image

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@coauthors
Copy link
Copy Markdown

coauthors bot commented Apr 14, 2026

People can be co-author:

Candidate Reasons Count Add this as commit message
@sukvvon #1953 1 Co-authored-by: sukvvon <66409882+sukvvon@users.noreply.github.com>
@codecov-commenter #1953 (comment) 1 Co-authored-by: codecov-commenter <65553080+codecov-commenter@users.noreply.github.com>

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 14, 2026

@sukvvon is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.22%. Comparing base (c7f885f) to head (8ace44d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1953   +/-   ##
=======================================
  Coverage   93.22%   93.22%           
=======================================
  Files          42       42           
  Lines         664      664           
  Branches      164      163    -1     
=======================================
  Hits          619      619           
  Misses         42       42           
  Partials        3        3           
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-query 95.83% <ø> (ø)
@suspensive/react-query-4 100.00% <ø> (ø)
@suspensive/react-query-5 100.00% <ø> (ø)
@suspensive/jotai 100.00% <ø> (ø)
@suspensive/codemods 81.60% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 14, 2026

⚠️ No Changeset found

Latest commit: 8ace44d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
suspensive-next-streaming-react-query Ready Ready Preview, Comment Apr 15, 2026 4:49am
v2.suspensive.org Ready Ready Preview, Comment Apr 15, 2026 4:49am
v3.suspensive.org Ready Ready Preview, Comment Apr 15, 2026 4:49am
visualization.suspensive.org Ready Ready Preview, Comment Apr 15, 2026 4:49am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants