🐛 fix(http): honor If-Match conditions - #1847
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
gaborbernat
force-pushed
the
fix/if-match-1150
branch
3 times, most recently
from
August 29, 2026 20:25
a7d8bad to
b1f7ec0
Compare
Management mutations accepted one numeric tag, treated weak tags as strong matches, and reported repository mismatches as conflicts instead of failed preconditions. Parse the RFC field once and carry its typed condition into the write transaction. This keeps existence checks, strong comparison, and mutation atomic while preserving authorization concealment.
gaborbernat
force-pushed
the
fix/if-match-1150
branch
from
August 29, 2026 20:41
b1f7ec0 to
9da1ef7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Management clients could send only one numeric entity tag. Weak tags matched as strong, and false repository preconditions returned
409 Conflict, contrary to RFC 9110 section 13.1.1.Peryx now parses RFC entity-tag lists and
*once, then passes a typed condition into the storage transaction. Visible false conditions return412 Precondition Failed; authorization failures still return404without reading the requested grant or repository.Closes #1150